fix: align Go toolchain versions for tomnomnom__gron task images#18
fix: align Go toolchain versions for tomnomnom__gron task images#18owwll wants to merge 1 commit into
Conversation
|
Hi @owwll! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
meta-cla
Bot
added
the
CLA Signed
1 participant
Fixes #9
Both task and task_cleanroom images for tomnomnom__gron.88a6234
were shipping with different Go versions:
task_cleanroom → go1.21.0
task → go1.24.2
This means a submission could be compiled against one toolchain
and evaluated against another, making benchmark results unreliable.
Fix: pinned both Dockerfiles to golang:1.21.0-alpine to match the
version declared in the project's go.mod.
Verified locally both containers now report the same Go version.